Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obtimizations and improvedments for run-install.sh #788

Merged
merged 2 commits into from
Oct 6, 2024

Conversation

rmdom-dev
Copy link
Contributor

Description

Obtimizations for run-install.sh and install ffmpeg funcion

Changes

Shebang Change: This now reflects #!/bin/bash for better compatibility with different systems. Error Handling: Added set -e to the beginning to make sure the script exits if any of the commands fail. Logging Function: I have implemented log_message() to log messages including their timestamps. Python Version Detection: I used the function find_python() which searches in order for python3.10, then python3, and finally python.
FFmpeg Installation: Improved install_ffmpeg() with command -v instead of which; improved Flatpak fallback mechanism.
Flatpak Installation: Improved install_ffmpeg_flatpak() to be able to install Flatpak if not present. Handling more package managers.
Virtual Environment Handling: The logic in prepare_install() and create_venv() has been improved to better create and activate the virtual environment.
Package Installation: Simplified logic around installing the dependencies; several verification steps were added to finish().

How has this been tested?

Tested on Ubuntu Cinnamon

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@blaisewf blaisewf merged commit 32443aa into IAHispano:main Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants