Obtimizations and improvedments for run-install.sh #788
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Obtimizations for
run-install.sh
and install ffmpeg funcionChanges
Shebang Change: This now reflects
#!/bin/bash
for better compatibility with different systems. Error Handling: Addedset -e
to the beginning to make sure the script exits if any of the commands fail. Logging Function: I have implementedlog_message()
to log messages including their timestamps. Python Version Detection: I used the functionfind_python()
which searches in order forpython3.10
, thenpython3
, and finallypython
.• FFmpeg Installation: Improved install_ffmpeg() with command -v instead of which; improved Flatpak fallback mechanism.
• Flatpak Installation: Improved install_ffmpeg_flatpak() to be able to install Flatpak if not present. Handling more package managers.
• Virtual Environment Handling: The logic in prepare_install() and create_venv() has been improved to better create and activate the virtual environment.
• Package Installation: Simplified logic around installing the dependencies; several verification steps were added to finish().
How has this been tested?
Tested on Ubuntu Cinnamon
Screenshots (if appropriate):
Types of changes
Checklist: